Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix if there extension has only one mime type (string) #1453

Merged
merged 1 commit into from
Nov 11, 2018

Conversation

nowackipawel
Copy link
Contributor

in_array() expects parameter 2 to be array, string given

APPPATH/Config/Mimes.php at line 316

Each pull request should address a single issue, and have a meaningful title.

 in_array() expects parameter 2 to be array, string given

APPPATH/Config/Mimes.php at line 316
@jim-parry
Copy link
Contributor

The resultig if statement is a bit of a mouthful, but valid :-/

@jim-parry jim-parry merged commit 220a761 into codeigniter4:develop Nov 11, 2018
@nowackipawel
Copy link
Contributor Author

You are correct I was wondering if I should change all extension values (mimes array) from strings to arrays... but this option was faster and there is literally no change in performance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants